edwardchalstrey1 / seshat

This is the beginning of the Seshat Project code.
1 stars 2 forks source link

Handle colours for polity components better #163

Closed edwardchalstrey1 closed 4 months ago

edwardchalstrey1 commented 5 months ago

One thing I thought is that it would be great if the individual polities of composites would have different colours, For example all the small states of the HRE which are selectable now just have the same color, not sure if this is possible.

The thing this raises is whether the current colouring regime of always going for the highest level, including for personal unions should be overturned.

Downside could be this causes legend chaos

Linked to #130

TODO

edwardchalstrey1 commented 5 months ago

Right now, I’m setting the colour based on the highest level composite, an alternate approach would be to set colour on the lowest level sub-polities, in which case I’d want to limit clicking to just highlight (and add to the legend) the sub-polity. An advantage would mean that on a Seshat polity page, you would get some Seshat polities that have several colours, so it’s clear to the viewer that sub-polities exist. I think on the world map however, you’d lose sight of large empires doing it this way, e.g. the British empire would look like a few separate entities across the world.

We could even assign each shape two colours and have the ability to toggle between the 2 settings, one where all the shapes in a composite have the same colour, and one where they vary based on sub-polity. That might be quite nice actually – best of both worlds!

edwardchalstrey1 commented 4 months ago

The way we handle overlapping shapes of components and members is a bit inconsistent currently