Closed edwardchalstrey1 closed 4 months ago
Right now, I’m setting the colour based on the highest level composite, an alternate approach would be to set colour on the lowest level sub-polities, in which case I’d want to limit clicking to just highlight (and add to the legend) the sub-polity. An advantage would mean that on a Seshat polity page, you would get some Seshat polities that have several colours, so it’s clear to the viewer that sub-polities exist. I think on the world map however, you’d lose sight of large empires doing it this way, e.g. the British empire would look like a few separate entities across the world.
We could even assign each shape two colours and have the ability to toggle between the 2 settings, one where all the shapes in a composite have the same colour, and one where they vary based on sub-polity. That might be quite nice actually – best of both worlds!
The way we handle overlapping shapes of components and members is a bit inconsistent currently
The thing this raises is whether the current colouring regime of always going for the highest level, including for personal unions should be overturned.
Downside could be this causes legend chaos
Linked to #130
TODO
and says "Selected components"Add test for thecliopatria_gdf
function inconvert_data.py
MemberOf
field for the personal union - this is a current inconsistency that makes it hard to display the personal union shapes without overlapping. Also mention to majid he will need to re-run migration.