search

edwardchalstrey1 / seshat

This is the beginning of the Seshat Project code.
0 stars 2 forks source link

Test re-writing history #173

Closed edwardchalstrey1 closed 5 days ago

edwardchalstrey1 commented 5 days ago

Attempt to re-write git history to avoid the existence of problem files highlighted by GitGuardian check

I have run seshat % git filter-branch --index-filter 'git rm -rf --cached --ignore-unmatch .github/workflows/build.yml' HEAD (see this stack post).

Would need to also run for tests.yml and local.py as suggested in the check, however attempting to do so for the former:

git filter-branch --index-filter 'git rm -rf --cached --ignore-unmatch .github/workflows/tests.yml' HEAD
WARNING: git-filter-branch has a glut of gotchas generating mangled history
     rewrites.  Hit Ctrl-C before proceeding to abort, then use an
     alternative filtering tool such as 'git filter-repo'
     (https://github.com/newren/git-filter-repo/) instead.  See the
     filter-branch manual page for more details; to squelch this warning,
     set FILTER_BRANCH_SQUELCH_WARNING=1.
Proceeding with filter-branch...

Cannot create a new backup.
A previous backup already exists in refs/original/
Force overwriting the backup with -f
edwardchalstrey1 commented 5 days ago

Conclusion: I don't think this is a particularly worthwhile endeavour. I think we should either ignore the check, or even just include the GitHub actions and changes to settings in the PR anyway