edwardhumi / pe

0 stars 0 forks source link

Improper class diagram #14

Open edwardhumi opened 2 months ago

edwardhumi commented 2 months ago

Class diagram in page 12 should have attributes and method in two different partitions image.png

soc-se-bot commented 2 months ago

Team's Response

image.png

While some of the partitions are attributes and the others are methods, as a developer, it should be evident enough as to which one are attributes and which ones are methods. Moreover, it is of accepted practice, as seen above. The parts of the classes that were omitted are not important for the task at hand.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Other than the partitions, the class diagram is still not following the correct syntax as it should not have the = sign, for example, in = new Scanner(System.in)


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.High`] - [x] I disagree **Reason for disagreement:** This is not a cosmetic problem