edwardkort / WWIDesigner

Wood Wind Instrument Designer
43 stars 8 forks source link

Add support for keyed toneholes #58

Open bhp1 opened 7 years ago

bhp1 commented 7 years ago

Hole class includes provision for defining a keypad that overhangs and closes the tonehole.

To support keyed toneholes, we need to enhance instrument views to define the keys, and the hole calculator to compute a transfer matrix for an open tonehole with overhanging keypad.

Equation 1.3.35 in Antoine's thesis gives a length correction for a tonehole with overhanging keypad, but he points out that the formula needs changes to cope with short toneholes.