edwardkort / WWIDesigner

Wood Wind Instrument Designer
43 stars 8 forks source link

double declaration in java fixes #76

Closed poulphunter closed 5 years ago

poulphunter commented 6 years ago

I have compared FEM results for brass instruments with this algorithm, I've seen some differences. After some investigation, the double declaration was'nt always well declared in Java. With double declaration fixed, my results where better :)

poulphunter commented 6 years ago

can you add me rights to make a pull requests (create branch / pull requests) to push my modifications ?

bhp1 commented 6 years ago

I don't have access to the repository permissions, but if you were to apply your changes to a fork of this repository, I could merge them into this repository.

edwardkort commented 6 years ago

For non-collaborators, the pull request process is best for all. Using git commands (or your favorite git client):

Then, the collaborators can look at the changes and do the appropriate merge.

And, since you have a GitHub login, you should need no additional permissions to do the above.

poulphunter commented 6 years ago

Thanks for the detailed process. I've created merge request https://github.com/edwardkort/WWIDesigner/pull/77

bhp1 commented 6 years ago

Thank you for the copious corrections. It will take me a while to check over all the details, but I will work on pulling them into the repository.

bhp1 commented 6 years ago

I've applied the explicit double type designator to constants for which it might be significant (those with a fractional part). Please pull the changes and see if they resolve the discrepancies you found.

edwardkort commented 5 years ago

No instances of unhandled (by the compiler) upcastings (float -> double, etc.) were found. Nonetheless, explicit double designators were made throughout the code with no changes observed in the calculated values.

With no further information received from the user, the issue is now closed.