search

edwardlai3582 / RobInDaHood

A desktop app for Robinhood
44 stars 14 forks source link

ETFs w/o Fundamental Data Throw Errors #6

Closed aberger91 closed 7 years ago

aberger91 commented 7 years ago

I've noticed that any product whose underlying does not have fundamentals (EPS, P/E, etc ..) will be blank, i. e. they will only show the background on the dashboard.

Examples of products are GLD and VXX (physical gold and options contracts do not have an EPS ratio, respectively). Any product whose underlying is unrelated to a company will throw.

The console error:

Uncaught TypeError: Cannot read property 'eps' of undefined at t.value (Earnings.js:54) at f._renderValidatedComponentWithoutOwnerOrContext (ReactCompositeComponent.js:799) at f._renderValidatedComponent (ReactCompositeComponent.js:822) at f.performInitialMount (ReactCompositeComponent.js:362) at f.mountComponent (ReactCompositeComponent.js:258) at Object.mountComponent (ReactReconciler.js:46) at f.performInitialMount (ReactCompositeComponent.js:371) at f.mountComponent (ReactCompositeComponent.js:258) at Object.mountComponent (ReactReconciler.js:46) at h.mountChildren (ReactMultiChild.js:238)

Should be an easy fix with an exception handler or something to check if fundamental data exists for a given product.

edwardlai3582 commented 7 years ago

@aberger91 have you tried the latest code? can't see the error on my side

aberger91 commented 7 years ago

@illl48 I did a fresh clone and rebuilt, the error is not happening anymore.

edwardlai3582 commented 7 years ago

@aberger91 gonna close this issue. Let me know if there are anymore bugs (should be alot) and feedback. Appreciate it.