search

edwardslabs / CloudBot

CloudBot - The simple, fast, expandable, open-source Python IRC Bot!
GNU General Public License v3.0
28 stars 31 forks source link

added support for optional [date] parameter for MFP plugin #174

Open edillingham opened 6 years ago

edillingham commented 6 years ago

uses python-dateutil to parse date strings instead of requiring a strict format

edwardslabs commented 6 years ago

For this one instead of adding a new requirement could you see if you could use the timeformat.py and timeparse.py in cloudbot/util/?

It does a nice job of formating time strings. Check remind.py for examples.

edwardslabs commented 6 years ago

Whoops didn't mean to close this.

edillingham commented 6 years ago

It doesn't look like cloudbot.util.time_parse supports anything to do with dates, which is what the plugin requires. I can remove the requirement and add a custom date parser if that's what the project prefers, but should we really reinvent the wheel?

linuxdaemon commented 6 years ago

All PRs for gonzobot should be submitted to snoonetIRC/CloudBot now.