search

edwardspec / mediawiki-aws-s3

Extension:AWS allows MediaWiki to use Amazon S3 (instead of the local directory) to store images.
https://www.mediawiki.org/wiki/Extension:AWS
GNU General Public License v2.0
42 stars 32 forks source link

Add Composer details #32

Closed samwilson closed 4 years ago

samwilson commented 4 years ago

Fix name etc. in composer.json, in preparation for adding to Packagist.

samwilson commented 4 years ago

I'm not sure what you think of registering this on Packagist, to make installation easier. But if you're into it, it needs a few tweaks in composer.json.

edwardspec commented 4 years ago

Now that MediaWiki core uses Guzzle too, it is inevitable that at some point the problem like #29 (caused by Extension:AWS and MediaWiki core installing different versions of Guzzle) would reappear.

So it's essential to be able to install Extension:AWS via composer.local.json (in base directory of MediaWiki core), similarly to how Semantic MediaWiki is installed.

samwilson commented 4 years ago

Good point.

I guess it'd even be possible to remove the guzzle requirement from AWS, given that it's in core (e.g. extensions don't explicitly add other libraries that they use if they're in core).

samwilson commented 4 years ago

Thanks for registering this on Packagist too by the way! I've updated the page on mediawiki.org.

anstosa commented 3 years ago

@edwardspec @samwilson has there been any movement here? I'm running into this now. Trying to use mediawiki-aws-s3 as part of a heroku deployment and the guzzle version conflict appears to be a blocking issue.

Edit: Removing guzzle entirely from the composer.json file and relying on the copy in mediawiki passes a quick smoke test but I don't know the project well enough to know what else needs to be done to make the change safely

samwilson commented 3 years ago

I think I tested it too and didn't find any issues. I guess guzzle should be removed from composer.json and the required MediaWiki version updated in extension.json to match whatever version guzzle was added to core in (unless that's long enough ago to not worry) — or just set it to 1.35, as the current stable version.

anstosa commented 3 years ago

Sweet, I'll figure that out and submit PR tomorrow. Thanks for the prompt reply!

samwilson commented 3 years ago

Great!

And I should add that I'm not the maintainer, so it's really up to @edwardspec :-)

edwardspec commented 3 years ago

or just set it to 1.35, as the current stable version.

Agreed. I'll make REL1_34 branch from current master (for MW 1.27-1.34), so the master branch can indeed be 1.35+.