search

edwardtufte / tufte-css

Style your webpage like Edward Tufte’s handouts.
https://edwardtufte.github.io/tufte-css/
MIT License
5.96k stars 458 forks source link

FYI #1

Closed clayh53 closed 9 years ago

clayh53 commented 9 years ago

I'm a total newbie at how pull requests are done, but anyway, thanks for doing most of the heavy lifting on the tufte-css repository. I forked your repository and added some CSS line-height and margin values so that all the sidenotes and marginnotes are on the same baseline typographic scale. I also added media queries so that the font sizes scale as the browser width changes. Anyway, if you want to add this to your original commit, please feel free. https://github.com/clayh53/tufte-css

daveliepmann commented 9 years ago

I think you opened a pull request to your own repository, instead of to mine...I'm not entirely sure how to rectify that! :)

I'm definitely interested in incorporating some of your changes. I think the best way to do that would be with multiple pull requests based on individual, targeted commits. For instance, one commit (and one pull request) for standardizing line-height and margins, one for media queries, and so one.

I also noticed you added an 'r' to ET Bembo...do I have the name wrong?

clayh53 commented 9 years ago

Okay, let me see if I can walk my way through this. The main things I mucked around with were the typographic scale related stuff plus added some media queries so that the line lengths stay sane when the browser resizes.

As far as the ETBrembo goes - that is a typo that crept in during my editing. I have fixed it now!

On Feb 7, 2015, at 3:54 PM, Dave Liepmann notifications@github.com wrote:

I think you opened a pull request to your own repository, instead of to mine...I'm not entirely sure how to rectify that! :)

I'm definitely interested in incorporating some of your changes. I think the best way to do that would be with multiple pull requests based on individual, targeted commits. For instance, one commit (and one pull request) for standardizing line-height and margins, one for media queries, and so one.

I also noticed you added an 'r' to ET Bembo...do I have the name wrong?

— Reply to this email directly or view it on GitHub.