search

edwardvmills / Silk

NURBS Surface modeling tools focused on low degree and seam continuity (FreeCAD Workbench)
https://edwardvmills.github.io/Silk/
62 stars 11 forks source link

README: Add LGTM badges #15

Closed luzpaz closed 1 year ago

luzpaz commented 4 years ago

Closes #14
ref: https://github.com/FreeCAD/FreeCAD-addons/issues/163

luzpaz commented 4 years ago

Preview: https://github.com/luzpaz/Silk/blob/LGTM/README.md

edwardvmills commented 4 years ago

when i look at the preview, i see a broken image link.

luzpaz commented 4 years ago

@edwardvmills you need to hard refresh to see the badges

edwardvmills commented 3 years ago

i'm still not clear on this one. do i need to do more than accept your change to readme.md that adds the banner or not? the LGTM link talks about adding a top level file, and setting up an account somewhere. that seems like too much work for me given how little time i have for the project itself.

If it's just the banner in the readme file, i'm ok with it. but i can't put a whole ton of effort into this just to be told my code is ugly :-) i already know my code is ugly.

luzpaz commented 3 years ago

It would be a simple .yml file. that we can use to exlcude certain files from analysis if needed.

edwardvmills commented 3 years ago

When i look at your branch, i don't see the "lgtm.yml" file i expect to see at the top level (based on info here). is it there and i'm blind, or did you only include the change to readme.md at this point?

luzpaz commented 3 years ago

I didn't add it [.lgtm.yml] yet :rofl:
But i can.

luzpaz commented 1 year ago

Closing since LGTM was sunset