search

edwardvmills / Silk

NURBS Surface modeling tools focused on low degree and seam continuity (FreeCAD Workbench)
https://edwardvmills.github.io/Silk/
60 stars 10 forks source link

Improve tooltips for icons so they actually describe what they do #22

Open luzpaz opened 3 years ago

luzpaz commented 3 years ago

Right now, many of the icons are just placeholder names of the icon name, for example: https://github.com/edwardvmills/Silk/blob/master/ControlGrid66.py#L57

edwardvmills commented 3 years ago

ok, that's a good one. i'll put it at the top of my todo list

luzpaz commented 3 years ago

I'll be happy to help. Also If I may, would you consider also formatting the code block in a more readable way? i.e.

def GetResources(self):
        return {'Pixmap' :  path_Silk_icons + '/ControlGrid66.svg', 
                        'MenuText': 'Insert text description', 
                        'ToolTip': 'Insert tooltip description'}

This way when it comes time to translate this workbench, it will be easier to do.

luzpaz commented 2 years ago

Maybe you have time to do this?

luzpaz commented 1 year ago

@edwardvmills softest of bumps

luzpaz commented 1 year ago

@wandrewkeech thanks for all your work on #28 While working on #32 I noticed that there are some tooltips that didn't get addressed for example:

https://github.com/edwardvmills/Silk/blob/affc35de21cfd3234918d0e5335f3d4b3a286889/ControlGrid3Star66_3Sub.py#L48

Any specific reason why ?

edwardvmills commented 1 year ago

i think that command/object was an early prototype, completely subsumed by ControlGridNStar66 (which covers the case where N=3)

maybe it could be deleted, but i probably left it there in case i wanted to pick things out of it.

edwardvmills commented 1 year ago

I just pushed a new system for tooltip + popup window for additional info by function. system is in place, 8/25 functions complete. hoping to complete this phase in one more week?

https://github.com/edwardvmills/Silk/commit/b7a4bf1388cb12633d724ab1efbb093cee879fc9

it is very challenging to say what the tools do :( as a lot of background info is required, as well as building up to the next tool in sequence.

right now i'm just putting extra info in the simplest Qt message window. long term i want to incorporate images and have the window scrollable. I also want the window to be dockable so it can be placed split screen with FreeCAD. Seems like i should be using Markup, not strings....

this was my very first Qt, so i want to take it slow. It's a step toward having all relevant info included in the workbench.