search

edwardvmills / Silk

NURBS Surface modeling tools focused on low degree and seam continuity (FreeCAD Workbench)
https://edwardvmills.github.io/Silk/
62 stars 11 forks source link

Added all missing icons #30

Closed wandrewkeech closed 1 year ago

wandrewkeech commented 1 year ago
edwardvmills commented 1 year ago

i would like to accept these, but i may end up tweaking/changing them in the future. the only thing i would want to change soon is the number of tick marks and little squares in SubGrid63_2Surf64 icon.

is that ok with you? i see this as a very useful contribution, but i might get the urge to make things 'just so' at some point.

alternatively, we could talk about it and i could tell you my needs, etc...i'm just not how much more time you want to spend on this yourself.

wandrewkeech commented 1 year ago

I am very happy to take notes and make changes on your behalf. This is very fast work for me, whereas writing macros is very very slow work.

edwardvmills commented 1 year ago

did you make this in inkscape or illustrator? the orignal set were made in inkscape. just curiosity, as long as it's compatible

edwardvmills commented 1 year ago

that's all i wanted to share, all the rest look great.

wandrewkeech commented 1 year ago

I'm a free software first kind of person, using PS or illustrator makes me absolutely crazy (so yes, I also was working in Inkscape).

Made up these two interpretations of your suggestions, please make further suggestions if needed; I'm not very confident I understood the vibe you were going for on SubGrid2Surf, but at least there are the right number of boxes.

edwardvmills commented 1 year ago

i merged and pulled it up in FeeCAD, looks great! thank you very much.

looks like something happened to the StarTrim icon. i had seen an icon with cutout center in the commits, but now i see a repeat of the star surface instead.

now i see that the grid44_rotate is not showing up either. i think i need to set the image links in the scripts.

edwardvmills commented 1 year ago

yes, all the icon files are there, now i just need to link them properly.

edwardvmills commented 1 year ago

hmm...if i fix the icon links, is it going to screw up your work on the tooltips? they are on the same line as of right now.

What do you think? should i fix the links or wait?