search

edwellbrook / node-tvdb

Node.js library for accessing TheTVDB API
https://edwellbrook.github.io/node-tvdb/
MIT License
66 stars 28 forks source link

Add get Episodes Summary #108

Closed ClementKerneur closed 6 years ago

edwellbrook commented 6 years ago

Hey @ClementKerneur! Thanks so much for the pull request. Look’s like there are some linting errors due to whitespace.

Additionally the PR is missing tests. If you can add some and fix the linting error, I’d love to get this merged in.

For reference, here’s a similar PR with tests: https://github.com/edwellbrook/node-tvdb/pull/81

Cheers!

ClementKerneur commented 6 years ago

Ok thanks, the PR #81 are exacly this equivalent.

So, I close this PR. Thanks you for response.

edwellbrook commented 6 years ago

@ClementKerneur I linked to that PR as an example of how to add tests to your PR. They are not the same 😄

If you would like to add tests and re-open this PR, I'd be happy to merge.

Thanks!

ClementKerneur commented 6 years ago

Thanks @edwellbrook i wasn't understand...

I've write test for this new methods and solve problems of linting.

I think that is now good :)

edwellbrook commented 6 years ago

Looks great. Thanks for updating that @ClementKerneur. Merged, updated the docs, and published a new version to npm (v4.1.0).

Thanks again for your contribution! 😄