Add Glide task - Githubissues

edwinakatosh / go-bamboo-plugin

Plugin for Atlassian Bamboo that adds support for Go language projects

Apache License 2.0

19 stars 4 forks source link

Add Glide task #10

Closed awarrenlove closed 6 years ago

awarrenlove commented 8 years ago

This adds a separate task to allow using Glide as the dependency manager instead of GoDep.

handcraftedbits commented 8 years ago

If it's alright, I have two suggestions:

The copyright info on the files you made has your name -- I would rather all files be consistent and say "HandcraftedBits", but I'll add a CONTRIBUTORS file with your information.
I'd like to use this as a basis to create a more generic dependency task that lets you select between multiple tools, in this case godep and glide, rather than a separate task for godep and a separate task for glide.

Does that sound reasonable? Thanks for the contribution BTW.

awarrenlove commented 8 years ago

That's perfectly fine by me. I'll take a look at this again to find a good way to combine them.

TheRaven commented 8 years ago

Hi,

Correct me if i'm wrong as I am new to Glide, but I think you might have to update the test runner as well. One issue I encountered with it, when running tests, is that if you use the flag -v ./..., it will run the tests inside the vendor folder unless you do something like go test $(glide nv)