search

edwinakatosh / go-bamboo-plugin

Plugin for Atlassian Bamboo that adds support for Go language projects
Apache License 2.0
19 stars 4 forks source link

go test exits with non zero exit code, so test parser never runs when tests fail #12

Open jeks313 opened 8 years ago

jeks313 commented 8 years ago

I must be missing something - the go test task exits with non-zero when a test fails, this means the next task which is meant to be the test parser never runs, which means my tests don't get parsed and shown in the interface.

Is this by design, or have I done something horribly wrong in my setup somewhere?

Failing test - skips to running post build steps ...

build 12-Oct-2016 14:29:34 FAIL build 12-Oct-2016 14:29:34 exit status 1 build 12-Oct-2016 14:29:34 FAIL bitbucket.org/fusemail/fm-utility-golang-trackerdb 0.007s simple 12-Oct-2016 14:29:34 Failing task since return code of [/usr/local/go/bin/go test -v .] was 1 while expected 0 simple 12-Oct-2016 14:29:34 Finished task 'Test' with result: Failed simple 12-Oct-2016 14:29:34 Running post build plugin 'NCover Results Collector'

Successful test - runs the test parser ...

build 12-Oct-2016 14:26:36 --- PASS: TestBase62 (0.00s) build 12-Oct-2016 14:26:36 PASS build 12-Oct-2016 14:26:36 ok bitbucket.org/fusemail/fm-utility-golang-trackerdb 0.004s simple 12-Oct-2016 14:26:36 Finished task 'Test' with result: Success simple 12-Oct-2016 14:26:36 Starting task 'Parse Tests' of type 'com.handcraftedbits.bamboo.plugin.go:task.go.test.parser' simple 12-Oct-2016 14:26:36 Parsing test results under /var/lib/bamboo/xml-data/build-dir/GO-TRAC-JOB1... simple 12-Oct-2016 14:26:36 Finished task 'Parse Tests' with result: Success

peternoyes commented 7 years ago

I am running into this as well. Any updates?

ghost commented 7 years ago

Same here. Updates @handcraftedbits ?

peternoyes commented 7 years ago

I was able to workaround this by having the test results parser be a "Final Task." This will cause the parser to run even if the tests fail. I think this is how it was designed to work.

ghost commented 7 years ago

Thanks @peternoyes

ghost commented 7 years ago

@peternoyes I did this but the test task still fails even if my tests pass.

diegomarcov commented 6 years ago

Happens to me as well, using Bamboo 6.3.0. My tests pass but go test returns a non zero code and the task fails because of that.