edwinb-ai / LeastSquaresSVM

A Least Squares Support Vector Machine implementation in pure Julia
https://edwinb-ai.github.io/LeastSquaresSVM/dev/
MIT License
1 stars 1 forks source link

Refactoring of kernels #25

Closed edwinb-ai closed 3 years ago

edwinb-ai commented 3 years ago

In this PR I have refactored the full code base to remove in-house kernel implementations and instead rely on well tested and robust code. I have chosen KernelFunctions.jl as it is quite well tested, has a lot of functionalities, and it's easy to use.

Closes #24

codecov[bot] commented 3 years ago

Codecov Report

Merging #25 (666f1db) into main (6e27916) will increase coverage by 6.25%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main       #25      +/-   ##
===========================================
+ Coverage   93.75%   100.00%   +6.25%     
===========================================
  Files           4         5       +1     
  Lines          80        93      +13     
===========================================
+ Hits           75        93      +18     
+ Misses          5         0       -5     
Impacted Files Coverage Δ
src/Elysivm.jl 100.00% <ø> (ø)
src/mlj_interface.jl 100.00% <100.00%> (ø)
src/training.jl 100.00% <100.00%> (ø)
src/types.jl 100.00% <100.00%> (+29.41%) :arrow_up:
src/utils.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6e27916...666f1db. Read the comment docs.