Handle NAs

[eusebe]

Hi,

Thank you for this very usefull package!

I tried the following code:

> y <- iris[1:3,]
> x <- y
> x$Sepal.Width[2] <- NA
> y
  Sepal.Length Sepal.Width Petal.Length Petal.Width Species
1          5.1         3.5          1.4         0.2  setosa
2          4.9         3.0          1.4         0.2  setosa
3          4.7         3.2          1.3         0.2  setosa
> x
  Sepal.Length Sepal.Width Petal.Length Petal.Width Species
1          5.1         3.5          1.4         0.2  setosa
2          4.9          NA          1.4         0.2  setosa
3          4.7         3.2          1.3         0.2  setosa
> patch <- diff_data(y, x)
> render_diff(patch)

@@	Sepal.Length	Sepal.Width	Petal.Length	Petal.Width	Species
	5.1	3.5	1.4	0.2	setosa
->	4.9	3->1.4	1.4->0.2	0.2->setosa	setosa->NULL
	4.7	3.2	1.3	0.2	setosa

Is it expected?

Best, David

[edwindj]

Thanks! You just uncovered a bug :-).

[edwindj]

Working on it: It has to do with the jsonlite communication:

jsonlite::toJSON(data.frame(a=1,b=NA))

results in

[{a: 1}]

[jeroen]

Perhaps you can use 'na=null' or na=string in tojson On Feb 23, 2015 6:54 AM, "Edwin de Jonge" notifications@github.com wrote:

Working on it: It has to do with the jsonlite communication:

jsonlite::toJSON(data.frame(a=1,b=NA))

results in

[{a: 1}]

— Reply to this email directly or view it on GitHub https://github.com/edwindj/daff/issues/5#issuecomment-75554927.

[edwindj]

@jeroenooms Thanks! I solved it differently: since daff.js uses a matrix internally I used jsonlite::toJSON(..., dataframe='values').

[eusebe]

Quick and clean, thanks! David