search

edwindj / ffbase

Basic (statistical) functionality for R package ff
github.com/edwindj/ffbase/wiki
35 stars 15 forks source link

Append factor levels in within.ffdf() #22

Closed nalimilan closed 11 years ago

nalimilan commented 11 years ago

This ensures that levels which do not appear in the first chunk are not discarded.

nalimilan commented 11 years ago

...and another related fix for ffdfappend().

BTW, I have a question about within.ffdf(): does it actually create RAM objects for every variable by chunks, or is there some kind of delayed evaluation so that only variables that are actually used as converted to RAM?

edwindj commented 11 years ago

I haven't checked your pull request yet, but it seems that it is not building (see travis warning in issue #22). Could you check your code please?

Best,

nalimilan commented 11 years ago

Ah, test cases are so useful. I hadn't payed attention to the case where x=NULL. The new version should work, let's wait for the test to pass.