search

edwindj / whisker

{{mustache}} for R
https://mustache.github.io
213 stars 19 forks source link

escaping german umlaute, when rendering into html #13

Closed michelk closed 7 years ago

michelk commented 10 years ago

This pull request escapes german-umlaute like ö,ä,ü, ... This is just tested under linux; not sure if the characters cause problems under other platforms (encoding). So maybe this shouldn't be merged; treat it as pointer for those who face similar problems.

edwindj commented 10 years ago

Thanks for your pull request: I will look into it next week.

I will look if there is a encoding issue: whisker should generate character vectors with the same encoding as the template. I don't think that whisker should be responsible for complete html escaping, except the core html characters (i.e. '<', '>', '&' and '"').