search

edwinhuish / better-comments-next

https://marketplace.visualstudio.com/items?itemName=EdwinHuiSH.better-comments-next
MIT License
33 stars 2 forks source link

No longer working in `.yml` files #12

Closed tylerlaprade closed 7 months ago

tylerlaprade commented 7 months ago 
on:
  push:
    branches:
      - 'develop'
      - 'main'
      - 'release/staging'
      - 'release/qa'
      # ! DON'T FORGET TO UNDO!!!

Expected behavior:

Everything from # ! onwards should be red

Actual behavior:

The whole comment is gray (default comment color)

edwinhuish commented 7 months ago

Does vscode correctly identified as yaml?

If yes, please give me more info to debug. Because this issue doesn't reproduce on my computer

tylerlaprade commented 7 months ago

Yes. I use the YAML extension from Red Hat: https://marketplace.visualstudio.com/items?itemName=redhat.vscode-yaml

The file is a regular GitHub Workflow definition. The original extension handles it still.

Better Comments Next

image

Better Comments

image
edwinhuish commented 7 months ago

better-comments-next only match comment begin with one space/tab to avoid match mistake. See https://github.com/edwinhuish/better-comments-next/issues/2#issuecomment-1868548243