edwinhuish / better-comments-next

https://marketplace.visualstudio.com/items?itemName=EdwinHuiSH.better-comments-next
MIT License
33 stars 2 forks source link

[Feature Request] Separate user tags from default tags #13

Open brccabral opened 6 months ago

brccabral commented 6 months ago

If I need to add a new tag, I need to have all default tags defined too, if not, the default tags won't highlight. So, I would like to suggest a new setting, better-comments.user_tags, by default empty, but if present it will add to the search, not replace it. Currently

// this will remove all tags, including the default ones, leaving only ^
"better-comments.tags": [
        {
            "tag": "^",
            "color": "#EAF622",
            "strikethrough": false,
            "underline": false,
            "backgroundColor": "transparent",
            "bold": false,
            "italic": false
        },
]

Feature request:

// default tags still exist, but user can create new ones without messing with default
"better-comments.user_tags": [
        {
            "tag": "^",
            "color": "#EAF622",
            "strikethrough": false,
            "underline": false,
            "backgroundColor": "transparent",
            "bold": false,
            "italic": false
        },
]
edwinhuish commented 6 months ago

You can use "better-comments.tagsLight" for light theme, and "better-comments.tagsDark" for dark theme. It's totally same as you want.

brccabral commented 6 months ago

Is there any priority between them or do I have to use both? Some projects I use light, others I use dark... If I am using dark, can I just set the "tagsLight"?

edwinhuish commented 6 months ago

Is there any priority between them

No, depends what kind of theme are you using.

Some projects I use light, others I use dark... If I am using dark, can I just set the "tagsLight"?

If you switch themes, you should set both to effect both.