search

edwtjo / evil-org-mode

Supplemental evil-mode keybindings to emacs org-mode
204 stars 37 forks source link

make evil leader bindings optional #10

Closed mijoharas closed 10 years ago

mijoharas commented 10 years ago

The evil leader bindings step on my setup so I made them optional. The default is to create the evil leader keybindings so nothing changes unless you use (setq evil-org-set-leader nil)

edwtjo commented 10 years ago

I think you missed a word. Also, how on earth do you survive without a leader!

mijoharas commented 10 years ago

Hahaha, I can't live without my leader, that's why I can't have you redefine my leader keys without me being able to say no. :smile:. Also, missed a word? key-bindings? or did I make a typo somewhere? Either way, thanks for the plugin.

edwtjo commented 10 years ago

Why can't you just reassign the leader keys after requiring the plugin? See the following example:

(require 'evil-org)
(evil-leader/set-key
  "t" (message "I pity the fool who can't reassign mr.T")
  "a" (message "Another win for the A-Team")
  "x" (message "Xtrodirnary emacsen")
)

It will use the bindings above not the one in the minor mode.

mijoharas commented 10 years ago

I can but that leaves me with a silent dependency between my settings and evil-org. I agree that it will work, I just like to leave things explicit so that it's maintainable ( avoids problems like "why did things break when I moved this line above that line... Oh, I see, so this line has to be before that line but after that one" e.t.c.). Thanks again.