edx / edx-arch-experiments

A plugin to include applications under development by the architecture team at edx
GNU Affero General Public License v3.0
0 stars 3 forks source link

Use a notifier plugin in GoCD #405

Open timmc-edx opened 11 months ago

timmc-edx commented 11 months ago

A/C

GoCD's built-in notifications system occasionally stops sending notifications, requiring manual intervention after server restart. We've also tried adding explicit failure/success calls to Opsgenie, but it's verbose and has various downsides.

Another option is to add a notifier plugin.

Implementation notes:

There are other APIs we can call; we may be able to send the output logs to Opsgenie by using the Artifacts API to retrieve cruise-output/console.log.

robrap commented 8 months ago

@timmc-edx: This has bubbled near the top of the on-call backlog, but doesn't strike me as more important than other work, including main focus work. What are your thoughts? Do you want to discuss as a team?

timmc-edx commented 8 months ago

I think it would be pretty quick to try the existing email notifier plugin, and likely worth the effort.

timmc-edx commented 8 months ago

Status: We're overall reasonably happy with the behavior of the current approach, in which we have calls to Opsgenie at the end of each job and in a separate stage at the end of each pipeline. However, it's a real bear to maintain—changing the pipeline (adding and removing jobs and stages, reordering, etc.) is now error-prone and involves a lot of extra code. So we'd likely still benefit from a proper notifier plugin, but more so if we're about to embark on changes to the edxapp pipelines.