Closed robrap closed 3 weeks ago
I guess this could have been an openedx-events issue, but oh well. We should inform the maintainers of the repo on the PR.
Diana posted this doc on the DEPR ticket: https://docs.openedx.org/en/latest/developers/how-tos/use-python-coverage-comment.html
The "Basic Usage" in the action's readme shows a two-workflow setup. We often didn't need this because we were adding the action to private repo, so no external contributions. The two-workflow setup allows tests to be run by untrusted contributors, and then trigger a section action that has credentials allowing it to finish.
With reduced access and the increase of forks, more pull requests will need the two-workflow setup. If an external pull request is used with the one-workflow setup, unfortunately, the workflow and all the jobs in the workflow succeed, but the comment hasn't been made. These messages are in the action's step:
Notice: HTTP Request: GET https://api.github.com/user "HTTP/1.1 403 Forbidden"
Notice: HTTP Request: GET https://api.github.com/repos/openedx/openedx-events/issues/[30](https://github.com/openedx/openedx-events/actions/runs/7467415648/job/20320880894#step:8:32)0/comments "HTTP/1.1 200 OK"
Notice: Adding new comment
Notice: HTTP Request: POST https://api.github.com/repos/openedx/openedx-events/issues/300/comments "HTTP/1.1 403 Forbidden"
Notice: Cannot post comment. This is probably because this is an external PR, so it's expected. Ensure you have an additional `workflow_run` step configured as explained in the documentation (or alternatively, give up on PR comments for external PRs).
Notice: Ending action
Status Update: We think that Ned's comment above about the need for two github actions is what needs to be worked on, and the linked PR that was closed just used the single action.
@feanil: Is this something that can be added to the Maintenance Working Group?
Yes, but I'm not sure how it will be prioritized at the moment.
@feanil: FYI: @timmc-edx will be looking into fixing https://github.com/edx/edx-arch-experiments/issues/437, which may be useful to the Maintenance WG for reviewing errors across repos.
Closing due to inactivity and not owning this repo. The team has done what it can for the codecov issue, and now the community will complete the effort.
Acceptance Criteria:
Additional repos
Codecov upload is now simply failing in some repos and we've removed it as a required check (and made it an optional upload step) to unblock merges. In these repos, we should come back and review this decision after the replacement is done in one repo. The ticket should cover 1) switching to the replacement choice, and 2) re-enabling any coverage checks that have been made optional in the following repos:
Background Context:
I've seen the codecov upload issue in openedx-events, so we'll fix there as an example.