edx / edx-arch-experiments

A plugin to include applications under development by the architecture team at edx
GNU Affero General Public License v3.0
0 stars 3 forks source link

[APM][Perf] Determine performance impact of DD APM agent #593

Closed robrap closed 6 months ago

robrap commented 7 months ago

We've seen impact in NR when adding the DD agent. This ticket is to confirm that we see a nearly equal performance win in DD when we drop NR APM.

Notes:

Acceptance Criteria:

robrap commented 6 months ago

Other things we might want to look for:

timmc-edx commented 6 months ago

Disabling NR on Edge showed roughly 15% improvement in median latency. Graphs below for LMS, CMS, and "Django" show the drop in latency around 16:00:

Image Image Image

(Bear in mind that these are log graphs to help make the change more obvious among various latency spikes. The improvement numbers are taken from averages extracted from various time spans.)

This appears to be in the same ballpark as the latency increase when adding DD to NR.

timmc-edx commented 6 months ago

Removed A/C "Confirm that code-owner information is still attached to DD traces (and that we weren't piggybacking on NR for this)" -- we actually aren't shipping this to DD yet. It does appear that we would be missing about 1% of code owner info with just DD, though: from Transaction select count(*) facet code_owner_transaction_name where code_owner_transaction_name is not null and appName = 'prod-edx-edxapp-lms' since 1 hour ago

robrap commented 6 months ago

Yay! Thanks @timmc-edx.