edx / edx-arch-experiments

A plugin to include applications under development by the architecture team at edx
GNU Affero General Public License v3.0
0 stars 3 forks source link

[APM] Remove direct references to newrelic #621

Closed timmc-edx closed 5 months ago

timmc-edx commented 6 months ago

We have some code in edx-platform (and possibly elsewhere) that directly imports and uses newrelic rather than going through edx-django-utils (e.g. in StaticContentServer). These all need to be switched over to edx-django-utils.

A/C:

Worklist:

robrap commented 5 months ago

Maybe most of this should be about informing maintainers?

timmc-edx commented 5 months ago

Yeah. I've gone ahead and just notified each team; they can migrate on their own schedule. I think the only thing left is this set_monitoring_transaction_name issue and I'm inclined to suggest that the owning team of the relying code should plan to set a new span tag and use that instead in their new dashboards and alerts (and we can deprecate that from e-d-u.)

robrap commented 5 months ago

I think the only thing left is this set_monitoring_transaction_name issue ...

Could we just document that as not being available for certain backends, in addition to your intended communications?

timmc-edx commented 5 months ago

It's already documented: https://github.com/openedx/edx-django-utils/tree/master/edx_django_utils/monitoring#choice-of-monitoring-tools

I haven't gone through and checked if other such newrelic-specific functions are used in the codebase, though.

timmc-edx commented 5 months ago

Filed https://github.com/openedx/edx-django-utils/issues/419 to cover the remaining NR-specific functions.