search

edx / edx-arch-experiments

A plugin to include applications under development by the architecture team at edx
GNU Affero General Public License v3.0
0 stars 3 forks source link

Arch-BOM PR review process updates #816

Closed robrap closed 1 month ago

robrap commented 1 month ago

See note at top of https://2u-internal.atlassian.net/wiki/spaces/AT/pages/16387065/On-Call+Arch-BOM#PR-Triage%2FReview for updated links.

Notes:

robrap commented 1 month ago

I DMed Michelle (sorry this link isn't public), but it is just so I can check back if I fail to hear back, or fail to update this ticket.

robrap commented 1 month ago

@dianakhuang: Maybe part of this should spin off as a separate arbi-bom ticket, unless you just discuss and update?

dianakhuang commented 1 month ago

We are more concerned with the backlog of upgrade bot PRs that are piling up. We will probably also need to create a separate stream of work around upgrades (arbi-bom) vs. other reviews(arch-bom).

robrap commented 1 month ago

Regarding the OSPR topic, I am taking the following as confirmation that this part is complete.

Questions from Robert:

Here are some hopefully more clear questions/confirmations:

  1. The Contributions board is still where we should be looking for PRs that need our attention, correct?
    • I think yes, but some of the views we used to use were removed, so I am just checking.
  2. For new PRs, if they are against a repo my team owns, then you will add 2u-arch-bom as "Repo Owner / Owning Team".
    • Confirming that that is the current process.
  3. I had a question of the status we should pay attention to, but decided to watch for anything that is not "Done". The link I had provided in my initial question had some status buried in the filter, but we'll just watch all status for now.
  4. Lastly, I believe you have a process for edx-platform with CCs and the new views that is working well enough for you? Or put another way, you are not expecting anything special on this front from my team that we aren't doing, right?

Responses from Michelle P.:

  1. Yes, the Contributions board is still where you should look. We cleaned up the views when the teams changed, but you can absolutely add an "arch-bom" view.
  2. Yes - for new PRs, if they are against arch-bom, I will add 2u-arch-bom as "Repo Owner / Owning Team".
  3. Re: the statuses, yes, anything that's not "Done" would be great. Tim and I do our best to make sure OSPRs have statuses up-to-date, but it takes a week or two for me to comb through all the ones I'm watching, so sometimes there are status changes that happen before Tim and I get to it (e.g. something might be ready for review, but not in that status yet because we haven't gotten back to it yet).
  4. The edx-platform view is all we really have right now for CCs to see which OSPRs in that repo need review, and there's lots still needing a reviewer. Nothing specific that arch-bom needs to do, but if you or another arch-bom member are able to review anything that's there, please feel free to do so!
robrap commented 1 month ago

Unfortunately, we can only filter out one bot (based on author) at a time (e.g. -author:edx-requirements-bot). If I add two of these filters, github just drops one. An alternative is to add a bot label (which one of these bots uses) for all bot PRs, so we can filter in or out bots as needed.

robrap commented 1 month ago

@dianakhuang: I moved the arbi-bom bot process questions to the following issue. Feel free to update its text as you wish.

The rest of this I have taken care of, so I am going to mark this ticket closed.