search

edx / upgrades

Coordination and support for major Open edX technology upgrades
Apache License 2.0
0 stars 0 forks source link

Update or replace django-threadlocals #36

Open Jawayria opened 3 years ago

Jawayria commented 3 years ago

We use the package django-threadlocals in edx/ecommerce. It hasn't yet added support for Django3.2. Please follow the guidance in https://openedx.atlassian.net/wiki/spaces/AC/pages/3036972032/Handling+Outdated+Dependencies to resolve the problem this poses for the Open edX Django 3.2 upgrade.

giovannicimolin commented 3 years ago

@e0d @Jawayria I'm looking at the e-commerce codebase and I'll try to replace threadlocals with crum (used in edx-platform) a simple local implementation.

giovannicimolin commented 3 years ago

PR here: https://github.com/edx/ecommerce/pull/3503

natabene commented 3 years ago

@giovannicimolin Thanks so much for an update.

natabene commented 2 years ago

From reviewing team: Thanks for this PR. But this change seems big for django32 upgrade work. Since django-crum already has django32 support so I suggest to use the master hash of the django-crum. Can you please replace the django-threadlocals with django-crum in separate PR.

You can leave this PR as it is for future use. Owning team can make such decisions.

giovannicimolin commented 2 years ago

@natabene I'll reply on the PR.

giovannicimolin commented 1 year ago

It's been a while since we had some activity here. I'll drop this task - unless anyone wants me to push this forward again.