search

edyan / docker-xhgui

An xhgui (with nginx, mongodb and php) container for profiling PHP Applications.
https://hub.docker.com/r/edyan/xhgui/
Apache License 2.0
25 stars 8 forks source link

Use docker COPY directice #10

Open glensc opened 4 years ago

glensc commented 4 years ago

you can replace this:


# Clone xhgui and install master as there is no suitable tag, then remove useless files
RUN     git clone -b 0.13.0 --depth 1 https://github.com/perftools/xhgui /usr/local/src/xhgui && \
        cd /usr/local/src/xhgui && \
        rm -rf /usr/local/src/xhgui/.git \
               /usr/local/src/xhgui/.scrutinizer.yml \
               /usr/local/src/xhgui/.travis.yml \
               /usr/local/src/xhgui/phpunit.xml \
               /usr/local/src/xhgui/README.md \
               /usr/local/src/xhgui/tests

with:

COPY --from=xhgui/xhgui:0.13.0 /var/www/xhgui /usr/local/src/xhgui

what does it mean "no suitable tag"? have you reported your issue to xhgui issue tracker?

edyan commented 4 years ago

Hi, I'll look at that, and thanks for your comment. It looks like xhgui and the profiler are now two separate packages (look at master + the docker image doesn't contain the external/ directory anymore, even in 0.13). Either I put both on the same image (that we can mount a common volume between apps) or I only install xhgui without profiler, with a doc for each ton integrate the profiler as he wish

About the "no suitable tag" it was when xhgui didn't maintained well its tags ;)

edyan commented 4 years ago

Hi @glensc , I have refactored my images for PHP > 7. I am relying now on the latest stable version of xhgui. They have removed the header.php script, so i have created mine. If you have time to test, I would be glad 👍

glensc commented 3 years ago

I'm not using this project, so I will not validate your outcome.

I see now, that you are using 0.14.0:

but you should update to at least the latest 0.16, so people don't need to rely on hacks:

in other words, this ended up in 0.16.0: