search

edzer / sp

Classes and methods for spatial data
http://edzer.github.io/sp/
127 stars 27 forks source link

CRS cache and updated CRS print method #103

Closed rsbivand closed 3 years ago

rsbivand commented 3 years ago

@edzer; any chance of a release? At least two packages were failing on Solaris because it runs PROJ 5.2.0 and GDAL 2.2.4, so helpfully the only CRAN instance still on proj_api.h. The fixes should help them at least a little.

edzer commented 3 years ago

Happy to do so - have you run revdep checks using this branch / PR?

rsbivand commented 3 years ago

Revdeps only on my fork master branch for these commits with PROJ 5.2.0 and 8.0.1; I don't trust branches across forks. ggOceanMaps https://github.com/MikkoVihtakari/ggOceanMaps/issues/6 and elevatr https://github.com/jhollist/elevatr/issues/56 pass the main problems, but elevatr still fails on 5.2.0 until they stop passing st_crs()$wkt to sp::CRS() but rather pass what I suggest in the issue. They turn off testing on solaris, but lose the opportunity to test older PROJ.

rsbivand commented 3 years ago

Last commit to my fork to add draft vignette for package test authors suggesting how to avoid problems with platforms running old rather than new PROJ. Comments welcome. No revdeps yet.

edzer commented 3 years ago

Let me know when I can give this a go (I mean, a merge + CRAN submission).

rsbivand commented 3 years ago

IIRC ready to go. On the road now, so no access to revdep check logs, but don't recall problems I noticed.

edzer commented 3 years ago

Thanks!

edzer commented 3 years ago

Ah, CRAN holidays...