search

eea / copernicus_quality_tools

European Union Public License 1.2
6 stars 1 forks source link

Pagination doesn't account for filters #23

Closed ch-koehler closed 1 week ago

ch-koehler commented 1 week ago

Issue

The pagination of the "My deliveries" table doesn't account for filters. Consider the following example:

grafik No filters set, everything as expected. We've got 16102 rows on 806 pages.

Now let's set a filter: grafik The table is being filtered as expected - we have 4 deliveries with a name that matches, but the pagination doesn't update: it still shows us 16102 rows on 806 pages, although - considering the filter - we have only 4 rows on a single page.

When trying to access any other page (i.e. 2 - 806), the frontend gets stuck, apparently trying to load data while there is none:

grafik

Expected behavior

Pagination should account for filtered deliveries, so in our example there should just be page 1.

System

QC tool version: 2.0.7 container from eeacms/copernicus-qctool-frontend:2.0.7.

tomicekj commented 1 week ago

@ch-koehler We have just published release 2.0.8, which implements a fix for a filtering bug in pagination deployment (https://github.com/eea/copernicus_quality_tools/releases/tag/2.0.8). Please test it and let me know if it is possible to close this issue.

ch-koehler commented 1 week ago

@tomicekj looks good to me! Thank you for the quick fix!