search

eea / eea.annotator

Inline comments for Plone
http://eea.github.com/docs/eea.annotator
0 stars 5 forks source link

Inline comments not saved on server side #1

Closed sureshvv closed 10 years ago

sureshvv commented 10 years ago

Version 2.1

I am able to add inline comments. The commented text is highlighted and hovering over it shows the comment.

Nothing gets saved on the server.

When I leave the page, comments are lost. Nothing shows up in the portlet.

I added a pdb breakpoint in eea/annotator/storage/handler.py in the add function. Did not break there at all.

What am I missing?

Thank you.

sureshvv commented 10 years ago

I am getting javascript exceptions:

Object has no method "off", "on" on view.js line nos. 324, 325

sureshvv commented 10 years ago

As I understand the on and off methods have the 1st argument as the event. The code seems to be using a selector instead (at least for the off method) on line 324

sureshvv commented 10 years ago

Need to use Plone 4.3.

olimpiurob commented 10 years ago

Hi sureshvv, eea.annotator has been built around plone.app.jquery 1.7.2 which is shipped by default with plone 4.3. If you wish to use it with an older version of plone, you could try pinning the plone.app.jquery to 1.7.2, but please keep in mind this could break functionality on other products you might have installed.