search

eea / volto-eea-kitkat

EEA Volto Add-ons bundle: A known good set of Volto addons to be used within all EEA projects
MIT License
5 stars 2 forks source link

module resolutions does not work #15

Closed nileshgulia1 closed 2 years ago

nileshgulia1 commented 2 years ago

Looks like the resolutions don't work in kitkat resulting one or more broken addon version being still pulled into the project.

As a workaround adding "resolutions" object in respective addon/project and pinning the needed overrides for an addon/module does solves the use case. I propose documenting it somewhere and making it futureproof.

avoinea commented 2 years ago

@nileshgulia1 You'll need to cleanup your project yarn.lock. Start with a fresh one from a new volto project:

See https://github.com/plone/volto-addon-ci#troubleshooting

avoinea commented 2 years ago

@nileshgulia1 Also update KitKat docs: https://github.com/eea/volto-eea-kitkat/tree/develop#resolutions

nileshgulia1 commented 2 years ago

@avoinea Thanks! I had an issue with volto-slate once, I fixed it already. Just to recap, these are the commands I followed up!

  1. create a project: npm init yo @plone/volto
  2. Install a new addon: @eeacms/volto-eea-kitkat
  3. yarn start

The slate is broken here. I rm yarn.lock and yarn install again, but still the error sustains. The commands here didn't helped.

I ended up writing my own resolution in package.json:

"resolutions" {
"volto-slate" : "4.2.1"
}

and yarn again. This works perfectly.

It also works by manual pinning to stable version of slate in yarn.lock.

nileshgulia1 commented 2 years ago

@nileshgulia1 Also update KitKat docs: https://github.com/eea/volto-eea-kitkat/tree/develop#resolutions

okay, This will help in someway. Thanks Alin,