search

eecs-autograder / autograder-server

GNU Lesser General Public License v3.0
8 stars 7 forks source link

Added `has_handgradeable_submission` to detect whether student group has at least one handgradeable submission #682

Closed Normanwqn closed 6 months ago

Normanwqn commented 6 months ago

Duplicating this pull request

To facilitate fixing this issue handling rejected student group's submission during handgrading, we needed an efficient way to tell whether a student group's has submitted any non-rejected submissions, we introduced a new field has_handgradeable_submission in data returned by ListHandgradingResultsView Django Rest API. has_handgradeable_submission is true if the student group has at least one submission on the autograder whose status is ag_models.Submission.GradingStatus.finished_grading, and false otherwise, when the student group has no submissions or all their submissions have been rejected.

Previous unit tests have been modified to accommodate this change. New unit tests and interfaces have been written to test student groups who only have rejected submissions.

Normanwqn commented 6 months ago

@james-perretta I have reopened another PR here.

I took a look at the Typescript CLI, and thought this change would be necessary as well.

james-perretta commented 6 months ago

Hmm CI still isn't running. I have an idea for another workaround, but probably won't get to it until monday. I'll let you know if I need anything else