Closed TheOmid closed 1 year ago
The spec from this PR is available at https://preview.sesh.rs/previews/eecs280staff/tutorials/100/.
(Available until Sun Feb 26 2023.)
The edits look good; thanks for making it more readable!
I have a couple of comments:
1- Since SSH is not super beginner friendly, that's why we decided to lean towards it. I think it would be good to make an SSH section instead of relying on GitHub (although in my opinion, it does a great job students told me they were confused). I can work on this!
2- You have removed hooks and delete_repo using a personal access token in the personal access token. Can they delete their repository without the token? (Is it to delete with an API call?). If the other two are API specific, we can ignore it, but it was also in GitHub's tutorial. Hence I included it.
Only thing I forgot to mention is that here:
"MacOS Pitfall: If you are not prompted for your username and password, your credentials may be cached on your computer. Clear your credentials from Keychain Access."
Do we probably want to say this if to Personal Access Token?
Also, maybe mention that with SSH you won't see a prompt for entering a password? I don't see SSH being mentioned as password-less authentication. @awdeorio @anishnya
Good catch. Could you make a separate PR with these proposed changes @TheOmid ?
Will do!
Add GitHub Authentication section that walks through SSH Keys and GitHub Personal Access Tokens.
A couple of notes:
I think the MacOS pitfall and expiration note can be more clear. LMK if you have suggestions for that I personally use SSH. I tested this with a new GitHub account, and the tutorial worked.
Closes #97