search

eecs280staff / tutorials

Tools and tutorials
https://eecs280staff.github.io/tutorials/
Other
5 stars 4 forks source link

WSL Non-Root User Check #166

Closed ohjuny closed 10 months ago

ohjuny commented 10 months ago

Fixes #165

Note: the uninstall link is a random article I found online because I couldn't find any uninstall instructions from our end. Should we add "official" uninstall instructions to this page, or is this fine?

github-actions[bot] commented 10 months ago

The spec from this PR is available at https://preview.sesh.rs/previews/eecs280staff/tutorials/166/.

(Available until Wed Feb 28 2024.)

awdeorio commented 10 months ago

As for creating official uninstall instructions, I'm hesitant based on my experience writing https://github.com/eecs280staff/tutorials/pull/99 - unsure if it's worth the maintenance burden. Also, I don't have a Windows machine, so I feel like it would just be copying instructions (and screenshots) from another online guide.

In office hours, I've been pointing students to this guide. They seemed to have no trouble following it, and it seemed to work fine. Thoughts on just using this link for now?

Great suggestion! Your idea is better.

ohjuny commented 10 months ago

Ready for review+merge!

ohjuny commented 10 months ago

LGTM after removing all the stray .DS_Store files. I'll approve so you can merge without me in the loop.

Apparently I don't have merge permissions in the tutorials repo :(

jamesjuett commented 10 months ago

Whoops, I had this on my to-do list for today but missed the boat on reviewing it. Overall, LGTM, but I'll follow up in a separate issue about a potential improvement on the uninstall instructions.