search

eecs485staff / madoop

A light weight MapReduce framework for education
MIT License
9 stars 4 forks source link

Tests #10

Closed awdeorio closed 2 years ago

awdeorio commented 2 years ago

Tweaks to the unit and system tests

Validation

$ git clean -xdf
$ python3 -m venv .venv
$ source env/bin/activate
$ pip install -e .
$ pylint madoop tests/* setup.py
$ pycodestyle madoop tests setup.py
$ pydocstyle madoop tests setup.py
$ pytest -vvsx

Closes #6

jaredzh commented 2 years ago

Should we also add test cases in test_api.py and test_cli.py that tests the optional argument jar hadoop-streaming-2.7.2.jar?

jaredzh commented 2 years ago

Also should we resolve #5 first before we merge?

awdeorio commented 2 years ago

Should we also add test cases in test_api.py and test_cli.py that tests the optional argument jar hadoop-streaming-2.7.2.jar?

Great point. This only needs to be address in test_cli.py, which should accept the same args as the real hadoop CLI. Fixed in 9e3bf675c146035a3685ccb34414d7107b0144c7

Also should we resolve #5 first before we merge? I think it's OK to merge this first.

awdeorio commented 2 years ago

@jaredzh Please approve and merge if you think this is good to go.