eecs485staff / madoop

A light weight MapReduce framework for education
MIT License
9 stars 4 forks source link

Group using Hash and Sort #33

Closed awdeorio closed 2 years ago

awdeorio commented 2 years ago

Modify the group stage to allocate lines to group by hash of key. Then, sort each group. This matches the Apache Hadoop Streaming interface.

Closes #12

codecov[bot] commented 2 years ago

Codecov Report

Merging #33 (f57255d) into develop (7e37a05) will decrease coverage by 0.09%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #33      +/-   ##
===========================================
- Coverage    93.98%   93.89%   -0.10%     
===========================================
  Files            4        4              
  Lines          133      131       -2     
===========================================
- Hits           125      123       -2     
  Misses           8        8              
Impacted Files Coverage Δ
madoop/mapreduce.py 95.28% <100.00%> (-0.09%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e37a05...f57255d. Read the comment docs.

jaredzh commented 2 years ago

Should I just ignore the failed checks from codecov? @awdeorio

awdeorio commented 2 years ago

Should I just ignore the failed checks from codecov? @awdeorio

Yea, that's fine for now

awdeorio commented 2 years ago

Bump @jaredzh !

jaredzh commented 2 years ago

I left a comment earlier, did you get a chance to look at it? @awdeorio

awdeorio commented 2 years ago

I left a comment earlier, did you get a chance to look at it?

The only comment I saw was a question about code cov, which I responded to. Maybe I missed somethign?

jaredzh commented 2 years ago

Hmm interesting, you should be able to see them under the "files changed" tab. Anyways, they were basically addressing the nitpicks I pushed. Take a look and go ahead and merge if it's good.