Convert toggle buttons to real buttons

eecs485staff / primer-spec

A Jekyll theme for sites with content-heavy pages

https://eecs485staff.github.io/primer-spec/

MIT License

22 stars 12 forks source link

Convert toggle buttons to real buttons #190

Closed seshrs closed 2 years ago

seshrs commented 2 years ago

I noticed that the sidebar and settings toggle buttons were anchors instead of real buttons 😅 It’s okay functionally, but is semantically incorrect (they don’t need the href attribute).

This PR updates the toggle buttons to be real <button> elements instead of anchors.

github-actions[bot] commented 2 years ago

The spec from this PR is available at https://preview.sesh.rs/previews/eecs485staff/primer-spec/190/.

^{(Available until Sat Aug 06 2022.)}