eecs485staff / primer-spec

A Jekyll theme for sites with content-heavy pages
https://eecs485staff.github.io/primer-spec/
MIT License
22 stars 12 forks source link

[Callouts] Match latest Primer styles and colors #211

Closed seshrs closed 2 years ago

seshrs commented 2 years ago

Context

The current Primer Spec callout colors were inspired by GitHub's dark mode colors (and were included in the original implementation #111). However, shortly after I merged the PR, GitHub updated their dark-mode callout styles!

Initially, I wasn't a fan of the new colors — they felt a bit too "flat". However, the styles have since grown on me, and I think it's time to match GitHub's styles.

This PR updates all callout colors to match the colors from GitHub's Primer Styles for their Alert component.

I also changed the demo callouts slightly to exclude italic styles.

Validation

BeforeAfter
Light mode image image
Dark mode image image

I think the new styles are more legible, especially in dark mode.

github-actions[bot] commented 2 years ago

The spec from this PR is available at https://preview.sesh.rs/previews/eecs485staff/primer-spec/211/.

(Available until Fri Oct 21 2022.)

awdeorio commented 2 years ago

I think the new styles are more legible, especially in dark mode.

I agree!