eecs485staff / primer-spec

A Jekyll theme for sites with content-heavy pages
https://eecs485staff.github.io/primer-spec/
MIT License
22 stars 12 forks source link

Markdown tables are not rendered #220

Closed santiagomed closed 1 year ago

santiagomed commented 1 year ago

Describe the bug Markdown tables are not rendered when using the primer spec theme.

To Reproduce Steps to reproduce the behavior:

  1. Add a markdown table to any .md document
  2. Serve the .md document using Github Pages and the primer-spec theme.
  3. If you try to see your table, it will show the plain-text instead of rendering correctly

Expected behavior The markdown table should be rendered as a table as shown here.

Specific Example The table should render as shown here It fails to do so in primer-spec, as shown here

Desktop (please complete the following information):

seshrs commented 1 year ago

Hi @santiagomed, thanks for using Primer Spec! I think it's pretty cool that you're using it for a non-course website. LMK if you run into issues / need support with your website's use of this theme 😃

In this case, it looks like Jekyll's built-in markdown processor (kramdown) didn't parse your table syntax. I'd need to see your Markdown source to be sure, but based on the HTML source, I think you just need to add an additional new line between your paragraph and your table. (Try adding a new line between lines 237 and 238 in your Markdown file.)

add a new line between lines 237 and 238

If that doesn't work, could you please either share your Markdown source, or a minimal snippet of Markdown code that reproduces the issue?

santiagomed commented 1 year ago

Hey! Thanks for the reply. I tried your suggestion and it worked! Thank you!