search

eecs485staff / primer-spec

A Jekyll theme for sites with content-heavy pages
https://eecs485staff.github.io/primer-spec/
MIT License
22 stars 12 forks source link

[Hotfix] Fix April Fools and Halloween jokes #243

Closed seshrs closed 1 year ago

seshrs commented 1 year ago

Context

While working on the PDF download feature (#225), I changed the classnames and structure of the Topbar. Unfortunately, this broke the April Fools and Halloween jokes! 😭

This PR fixes the jokes, and also adds a reminder to the Topbar module to fix the jokes if this file changes. I don't want students to miss this year's April Fools Languages joke (#197)!

Validation

Visit any page on the preview website and append ?enable_halloween=1 or ?enable_april_fools_languages=1 to the URL.

Examples:

github-actions[bot] commented 1 year ago

The spec from this PR is available at https://preview.sesh.rs/previews/eecs485staff/primer-spec/243/.

(Available until Mon Feb 20 2023.)