[Bugfix] Make image backgrounds transparent

eecs485staff / primer-spec

A Jekyll theme for sites with content-heavy pages

https://eecs485staff.github.io/primer-spec/

MIT License

22 stars 12 forks source link

[Bugfix] Make image backgrounds transparent #259

Closed seshrs closed 6 months ago

seshrs commented 6 months ago

While optimizing the spec of EECS 280's new Project 4 (Editor) for dark mode images, I noticed that MacOS screenshots were always showing with a white background. It turns out that the base Primer CSS styles always render images with a white background!

Since Primer Spec manages the background of the page, we should just let images with transparency blend with the page's background color.

Before	After

github-actions[bot] commented 6 months ago

The spec from this PR is available at https://preview.sesh.rs/previews/eecs485staff/primer-spec/259/.

^{(Available until Sat Apr 13 2024.)}