eecs485staff / primer-spec

A Jekyll theme for sites with content-heavy pages
https://eecs485staff.github.io/primer-spec/
MIT License
22 stars 13 forks source link

Jekyll Build fail due to logger #266

Open nelsontm opened 2 months ago

nelsontm commented 2 months ago

@seshrs see bug details and (temporary?) fix in https://github.com/eecs370/project_1_spec/issues/32

Can this be fixed directly from primer spec or do we need to copy the fix to all of our spec repos? (@hmuench7 if so, add to your to-dos for other projects)

seshrs commented 2 months ago

Nice find, thanks for investigating and sharing! 🚀

I think this can be fixed for all repos by adding the dependency constraint to Primer Spec’s gemspec. @nelsontm / @hmuench7: Would you like to help put up a PR?

(Alternatively, I can get to it during the weekend.)

nelsontm commented 2 months ago

With the back-to-school tasks, I won't be able to get to it for a while. Guessing the same for @hmuench7?

hmuench7 commented 2 months ago

Yes same for me