eed3si9n / gigahorse

Gigahorse is an HTTP client for Scala with multiple backend support.
http://eed3si9n.com/gigahorse
Apache License 2.0
121 stars 25 forks source link

Stream#underlying should return A instead of Unit? #52

Closed xuwei-k closed 5 years ago

xuwei-k commented 6 years ago

procedure syntax 😢

We should fix

- def underlying[A]
+ def underlying[A]: Unit

or

- def underlying[A]
+ def underlying[A]: A

? 🤔

eed3si9n commented 6 years ago

It should be def underlying[A]: A.