Closed mrdziuban closed 1 year ago
Thanks @eed3si9n, updated to upgrade the sbt-nocomma
dependency instead of remove it
Looks like my GitHub Actions have gone stale somehow since tests are not running on this PR?
Yeah that's strange, not sure why. Let me know if I can do anything to help
Looks like my GitHub Actions have gone stale somehow since tests are not running on this PR?
I know workflows go idle after 60 days if there has been no action. Maybe that's what's happening here?
Yea, maybe because I have a weekly cron section in the workflow to catch changes to outside resource? Does it wake up after making some commits?
Yea, maybe because I have a weekly cron section in the workflow to catch changes to outside resource? Does it wake up after making some commits?
Can you manually trigger it? There might be a "re-enable" in the actions view.
Removing cron job seems to fix it - https://github.com/eed3si9n/scalaxb/pull/592
👍 just cherry-picked the commit from #592 and also updated to sbt 1.8.0
@mrdziuban Given sbt 1.8.0 still uses parser-combinators 1.x, we might want to hold off on bumping that to 2.x to avoid yet another dependency multiverse issue.
Here's my PR for this - https://github.com/eed3si9n/scalaxb/pull/593
This updates the dependency on
scala-xml
to2.1.0
for scala 2.13 andscala-parser-combinators
to2.1.1
for scala 2.12 and 2.13.As a side effect, I also removed
sbt-nocomma
since it has a dependency onscalatest:3.0.4
which depends onscala-xml:1.0.5
. It looks like if a new version ofsbt-nocomma
is released with the change from sbt/sbt-nocomma#7 then this wouldn't be necessary.