eed3si9n / scalaxb

scalaxb is an XML data binding tool for Scala.
http://scalaxb.org/
MIT License
335 stars 154 forks source link

Upgrade to scala-xml and scala-parser-combinators 2.x versions #589

Closed mrdziuban closed 1 year ago

mrdziuban commented 1 year ago

This updates the dependency on scala-xml to 2.1.0 for scala 2.13 and scala-parser-combinators to 2.1.1 for scala 2.12 and 2.13.

As a side effect, I also removed sbt-nocomma since it has a dependency on scalatest:3.0.4 which depends on scala-xml:1.0.5. It looks like if a new version of sbt-nocomma is released with the change from sbt/sbt-nocomma#7 then this wouldn't be necessary.

eed3si9n commented 1 year ago

Released https://github.com/sbt/sbt-nocomma/releases/tag/v0.1.1

mrdziuban commented 1 year ago

Thanks @eed3si9n, updated to upgrade the sbt-nocomma dependency instead of remove it

eed3si9n commented 1 year ago

Looks like my GitHub Actions have gone stale somehow since tests are not running on this PR?

mrdziuban commented 1 year ago

Yeah that's strange, not sure why. Let me know if I can do anything to help

ckipp01 commented 1 year ago

Looks like my GitHub Actions have gone stale somehow since tests are not running on this PR?

I know workflows go idle after 60 days if there has been no action. Maybe that's what's happening here?

eed3si9n commented 1 year ago

Yea, maybe because I have a weekly cron section in the workflow to catch changes to outside resource? Does it wake up after making some commits?

ckipp01 commented 1 year ago

Yea, maybe because I have a weekly cron section in the workflow to catch changes to outside resource? Does it wake up after making some commits?

Can you manually trigger it? There might be a "re-enable" in the actions view.

eed3si9n commented 1 year ago

Removing cron job seems to fix it - https://github.com/eed3si9n/scalaxb/pull/592

mrdziuban commented 1 year ago

👍 just cherry-picked the commit from #592 and also updated to sbt 1.8.0

eed3si9n commented 1 year ago

@mrdziuban Given sbt 1.8.0 still uses parser-combinators 1.x, we might want to hold off on bumping that to 2.x to avoid yet another dependency multiverse issue.

eed3si9n commented 1 year ago

Here's my PR for this - https://github.com/eed3si9n/scalaxb/pull/593