search

eed3si9n / sjson-new

a typeclass based JSON codec that's backend independent
Apache License 2.0
36 stars 19 forks source link

upgrade jawn, Scala, sbt, MiMa #111

Closed SethTisue closed 4 years ago

SethTisue commented 4 years ago

the reason I'm interested in the jawn upgrade is https://github.com/scala/community-build/pull/1131 but it's almost certainly a good thing regardless

SethTisue commented 4 years ago

CI failure seems to be "[error] java.lang.RuntimeException: mimaPreviousArtifacts not set, not analyzing binary compatibility", mind if I stop here and let you finish it off if you're interested?

SethTisue commented 4 years ago

Note that I have no idea what those unused index parameters in the diffs are about or whether it's okay they're unused. But the tests pass 🤷

eed3si9n commented 4 years ago

There's been previous PRs to update Jawn (https://github.com/eed3si9n/sjson-new/pull/85, https://github.com/eed3si9n/sjson-new/pull/96), but I refrained from it since I was afraid of bincompat breakage that may leak out to sbt. Maybe it's better to bite the bullet and let the chips fall.

SethTisue commented 4 years ago

I think this PR is safe, because you are already using different jawn versions for 2.12 and 2.13, and this PR only modifies 2.13-specific stuff.

No opinion on the other PRs.

eed3si9n commented 4 years ago

Right. I guess I did the conditional thing in https://github.com/eed3si9n/sjson-new/pull/106 thanks for the reminder.