Reconsider the name of the "project" method on AdditionalFormats

eed3si9n / sjson-new

a typeclass based JSON codec that's backend independent

Apache License 2.0

36 stars 19 forks source link

Closed dwijnand closed 7 years ago

dwijnand commented 7 years ago

AdditionalFormats is mixed into BasicJsonProtocol (and from there into other implicit cakes).

This means that importing sjsonew.BasicJsonProtocol._ will make project ambiguous between sbt's (macro) method) and this method.

I found this in fixing scripted tests when switching from sbinary to sjsonnew.

Feel free to close if you consider this a non-issue.

eed3si9n commented 7 years ago

Yea. Since these are frequently imported, I'm ok with adding prefixes like projectFormat and liftFormat.