eed3si9n / treehugger

treehugger.scala is a library to code Scala programmatically.
http://eed3si9n.com/treehugger
Other
133 stars 20 forks source link

DocGen generating JavaDoc style, not ScalaDoc style comments #30

Closed julianpeeters closed 7 years ago

julianpeeters commented 8 years ago

Hi again,

I notice that treehugger produces JavaDoc style when I believe the intent is to produce ScalaDoc style. [Treehugger's documentation] shows the issue: (http://eed3si9n.com/treehugger/comments.html#Scaladoc+style+comments), while here is the ScalaDoc spec.

The differences that ScalaDoc adopts seem to be: 1) Text always begins on the first line, after /* 2) ""s that begin new comment lines in multiline comments should be aligned in the 3rd column rather than the second.

Not really sure this is a pressing issue. I'd suspect that JavaDoc style is pretty compatible with most ScalaDoc parsers (?). Also, it appears that intellij seems to have the same issue (using JavaDoc style for ScalaDocs), and that doesn't seem to cause much trouble.

So not really an issue for me, but I thought I should report this.

eed3si9n commented 8 years ago

Thanks for the report.

eed3si9n commented 8 years ago

+1 on fixing this. I'd accept PR for this if you're up for it.

julianpeeters commented 8 years ago

Yup, I'll take a swing.

eed3si9n commented 7 years ago

I've since then looked into the ScalaDoc styling, and came to conclusion that "JavaDoc" style should be the standard. See https://github.com/scalameta/scalafmt/issues/891

julianpeeters commented 7 years ago

:+1:

eed3si9n commented 7 years ago

Closing this.