eeditiones / eltec

Demo app for data from European Literary Text Collection (ELTeC)
GNU General Public License v3.0
2 stars 1 forks source link

cant select multiple facet values #3

Closed lb42 closed 3 years ago

lb42 commented 3 years ago

it doesnt seem possible to make multiple selections from a given facet. consequently you cannot search for texts which appear in more than one timeslot, or more than one language. This is a problem, especially since "english" appears twice in the list of languages, once for level0 and once for level1 encodings (I think).

tuurma commented 3 years ago

English appears twice due to inconsistency in attribute values for TEI/@xml:lang (eng and ENG, respectively). I think that there is only one value per document for TEI/@xml:lang , multiple values are available in profileDesc/langUsage

Multiple selection for facets is supported server-side but lacks support in UI. There is a relevant issue in Publisher tracker, currently in need of funding https://github.com/eeditiones/tei-publisher-app/issues/33

tuurma commented 3 years ago

Sorry, en (correct) and 13 cases of ENG (incorrect). Spanish use SPA instead of es.

tuurma commented 3 years ago

Adding manually the other facet value to the URL would present correct data set, just UI is wrong

image

tuurma commented 3 years ago

after the fix correcting display of selected facets

image

lb42 commented 3 years ago

Thanks for spotting this inconsistency in time for the next release: I am correcting the data in github right now.

lb42 commented 3 years ago

ELTeC-en data is now correct. Leaving this ticket open to remind me to fix SPA, but also because selection by multiple facet values is a real requirement for this project. Another example: selecting texts from timeslots before/after 1870. How much funding does it need? If the server already supports this, it can't be that hard!

tuurma commented 3 years ago

Ha, common misconception. Server-side stuff is usually 10-20% of the time, user interface is pain and misery ;-)

I'd estimate 1 day. Needs to be configurable between current behaviour and only sending the request after choosing facets by some kind of Apply/Submit button.

tuurma commented 3 years ago

Fixed. Not sure I like it - one needs to go down the list of facets to press the SUBMIT button now

image